Re: [PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-28 Thread David Miller
From: Jian Shen Date: Wed, 28 Aug 2019 09:34:47 +0800 > Some ethernet drivers may call phy_start() and phy_stop() from > ndo_open() and ndo_close() respectively. > > When network cable is unconnected, and operate like below: > step 1: ifconfig ethX up -> ndo_open -> phy_start ->start > autoneg,

Re: [PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread Heiner Kallweit
On 28.08.2019 03:34, Jian Shen wrote: > Some ethernet drivers may call phy_start() and phy_stop() from > ndo_open() and ndo_close() respectively. > > When network cable is unconnected, and operate like below: > step 1: ifconfig ethX up -> ndo_open -> phy_start ->start > autoneg, and phy is no link

[PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread Jian Shen
Some ethernet drivers may call phy_start() and phy_stop() from ndo_open() and ndo_close() respectively. When network cable is unconnected, and operate like below: step 1: ifconfig ethX up -> ndo_open -> phy_start ->start autoneg, and phy is no link. step 2: ifconfig ethX down -> ndo_close -> phy_s

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/28 3:41, Heiner Kallweit 写道: > On 27.08.2019 10:29, shenjian (K) wrote: >> >> >> 在 2019/8/27 13:51, Heiner Kallweit 写道: >>> On 27.08.2019 04:47, Jian Shen wrote: Some ethernet drivers may call phy_start() and phy_stop() from ndo_open and ndo_close() respectively. Whe

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread Heiner Kallweit
On 27.08.2019 10:29, shenjian (K) wrote: > > > 在 2019/8/27 13:51, Heiner Kallweit 写道: >> On 27.08.2019 04:47, Jian Shen wrote: >>> Some ethernet drivers may call phy_start() and phy_stop() from >>> ndo_open and ndo_close() respectively. >>> >>> When network cable is unconnected, and operate like

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/27 18:11, Sergei Shtylyov 写道: > On 27.08.2019 5:47, Jian Shen wrote: > >> Some ethernet drivers may call phy_start() and phy_stop() from >> ndo_open and ndo_close() respectively. > >    ndo_open() for consistency. > >> When network cable is unconnected, and operate like below: >> ste

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread Sergei Shtylyov
On 27.08.2019 5:47, Jian Shen wrote: Some ethernet drivers may call phy_start() and phy_stop() from ndo_open and ndo_close() respectively. ndo_open() for consistency. When network cable is unconnected, and operate like below: step 1: ifconfig ethX up -> ndo_open -> phy_start ->start auton

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-27 Thread shenjian (K)
在 2019/8/27 13:51, Heiner Kallweit 写道: > On 27.08.2019 04:47, Jian Shen wrote: >> Some ethernet drivers may call phy_start() and phy_stop() from >> ndo_open and ndo_close() respectively. >> >> When network cable is unconnected, and operate like below: >> step 1: ifconfig ethX up -> ndo_open -> p

Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-26 Thread Heiner Kallweit
On 27.08.2019 04:47, Jian Shen wrote: > Some ethernet drivers may call phy_start() and phy_stop() from > ndo_open and ndo_close() respectively. > > When network cable is unconnected, and operate like below: > step 1: ifconfig ethX up -> ndo_open -> phy_start ->start > autoneg, and phy is no link.

[RFC PATCH net-next] net: phy: force phy suspend when calling phy_stop

2019-08-26 Thread Jian Shen
Some ethernet drivers may call phy_start() and phy_stop() from ndo_open and ndo_close() respectively. When network cable is unconnected, and operate like below: step 1: ifconfig ethX up -> ndo_open -> phy_start ->start autoneg, and phy is no link. step 2: ifconfig ethX down -> ndo_close -> phy_sto