Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 18:04, Vladimir Oltean wrote: > On Thu, Mar 18, 2021 at 05:38:13PM +0100, Michael Walle wrote: >> Am 2021-03-18 17:21, schrieb Heiner Kallweit: >>> On 18.03.2021 16:17, Vladimir Oltean wrote: On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: > On 18.03.2021 15:

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Vladimir Oltean
On Thu, Mar 18, 2021 at 05:38:13PM +0100, Michael Walle wrote: > Am 2021-03-18 17:21, schrieb Heiner Kallweit: > > On 18.03.2021 16:17, Vladimir Oltean wrote: > > > On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: > > > > On 18.03.2021 15:23, Michael Walle wrote: > > > > > at803x_an

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Michael Walle
Am 2021-03-18 17:21, schrieb Heiner Kallweit: On 18.03.2021 16:17, Vladimir Oltean wrote: On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: On 18.03.2021 15:23, Michael Walle wrote: at803x_aneg_done() is pretty much dead code since the patch series "net: phy: improve and simplif

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 16:17, Vladimir Oltean wrote: > On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: >> On 18.03.2021 15:23, Michael Walle wrote: >>> at803x_aneg_done() is pretty much dead code since the patch series >>> "net: phy: improve and simplify phylib state machine" [1]. Remove it

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Vladimir Oltean
On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: > On 18.03.2021 15:23, Michael Walle wrote: > > at803x_aneg_done() is pretty much dead code since the patch series > > "net: phy: improve and simplify phylib state machine" [1]. Remove it. > > > > Well, it's not dead, it's resting .

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 15:23, Michael Walle wrote: > at803x_aneg_done() is pretty much dead code since the patch series > "net: phy: improve and simplify phylib state machine" [1]. Remove it. > Well, it's not dead, it's resting .. There are few places where phy_aneg_done() is used. So you would need to ex

[PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Michael Walle
at803x_aneg_done() is pretty much dead code since the patch series "net: phy: improve and simplify phylib state machine" [1]. Remove it. [1] https://lore.kernel.org/netdev/922c223b-7bc0-e0ec-345d-2034b796a...@gmail.com/ Suggested-by: Vladimir Oltean Signed-off-by: Michael Walle --- drivers/ne