Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-21 Thread Heiner Kallweit
On 21.03.2019 09:38, Andrew Lunn wrote: > On Wed, Mar 20, 2019 at 10:15:10PM +0100, Heiner Kallweit wrote: >> Aquantia PHY's of the AQR107 family support the downshift feature. >> Add support for it as standard PHY tunable so that it can be controlled >> via ethtool. >> The AQCS109 supports a propr

Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-21 Thread Florian Fainelli
On 3/21/19 9:30 AM, David Miller wrote: > From: Andrew Lunn > Date: Thu, 21 Mar 2019 09:38:27 +0100 > >> Even for a downshift to 1000Base-T2, i'm guessing for most use cases, >> this means the cable is partially broken, and it serves as an early >> warning it needs replacing. > > +1 Maybe somet

Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-21 Thread David Miller
From: Andrew Lunn Date: Thu, 21 Mar 2019 09:38:27 +0100 > Even for a downshift to 1000Base-T2, i'm guessing for most use cases, > this means the cable is partially broken, and it serves as an early > warning it needs replacing. +1

Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-21 Thread Andrew Lunn
On Wed, Mar 20, 2019 at 10:15:10PM +0100, Heiner Kallweit wrote: > Aquantia PHY's of the AQR107 family support the downshift feature. > Add support for it as standard PHY tunable so that it can be controlled > via ethtool. > The AQCS109 supports a proprietary 2-pair 1Gbps mode. If two such PHY's >

Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-20 Thread Florian Fainelli
On 3/20/19 2:15 PM, Heiner Kallweit wrote: > Aquantia PHY's of the AQR107 family support the downshift feature. > Add support for it as standard PHY tunable so that it can be controlled > via ethtool. > The AQCS109 supports a proprietary 2-pair 1Gbps mode. If two such PHY's > are connected to each

[PATCH net-next] net: phy: aquantia: add downshift support

2019-03-20 Thread Heiner Kallweit
Aquantia PHY's of the AQR107 family support the downshift feature. Add support for it as standard PHY tunable so that it can be controlled via ethtool. The AQCS109 supports a proprietary 2-pair 1Gbps mode. If two such PHY's are connected to each other with a 2-pair cable, they may not be able to es