Re: [PATCH net-next] net: phy: Ensure scheduled work is cancelled during removal

2019-06-01 Thread Andrew Lunn
On Fri, May 31, 2019 at 09:22:16PM -0600, hanc...@sedsystems.ca wrote: > > On 31.05.2019 22:54, Andrew Lunn wrote: > >>> It is possible that scheduled work started by the PHY driver is still > >>> outstanding when phy_device_remove is called if the PHY was initially > >>> started but never connecte

Re: [PATCH net-next] net: phy: Ensure scheduled work is cancelled during removal

2019-05-31 Thread hancock
> On 31.05.2019 22:54, Andrew Lunn wrote: >>> It is possible that scheduled work started by the PHY driver is still >>> outstanding when phy_device_remove is called if the PHY was initially >>> started but never connected, and therefore phy_disconnect is never >>> called. phy_stop does not guarante

Re: [PATCH net-next] net: phy: Ensure scheduled work is cancelled during removal

2019-05-31 Thread Heiner Kallweit
On 31.05.2019 22:54, Andrew Lunn wrote: > Robert > > Please make sure you Cc: PHY patches to the PHY maintainers. > > Heiner, this one is for you. > > Andrew > > On Fri, May 31, 2019 at 01:15:50PM -0600, Robert Hancock wrote: >> It is possible that scheduled work started by the PHY driver

Re: [PATCH net-next] net: phy: Ensure scheduled work is cancelled during removal

2019-05-31 Thread Andrew Lunn
Robert Please make sure you Cc: PHY patches to the PHY maintainers. Heiner, this one is for you. Andrew On Fri, May 31, 2019 at 01:15:50PM -0600, Robert Hancock wrote: > It is possible that scheduled work started by the PHY driver is still > outstanding when phy_device_remove is called

[PATCH net-next] net: phy: Ensure scheduled work is cancelled during removal

2019-05-31 Thread Robert Hancock
It is possible that scheduled work started by the PHY driver is still outstanding when phy_device_remove is called if the PHY was initially started but never connected, and therefore phy_disconnect is never called. phy_stop does not guarantee that the scheduled work is stopped because it is called