Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/15/21 10:36 PM, Arnd Bergmann wrote: On Fri, Jan 15, 2021 at 6:24 PM Heiner Kallweit wrote: On 15.01.2021 16:59, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: On 1/15/21 4:00 PM, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut w

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Arnd Bergmann
On Fri, Jan 15, 2021 at 6:24 PM Heiner Kallweit wrote: > On 15.01.2021 16:59, Andrew Lunn wrote: > > On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: > >> On 1/15/21 4:00 PM, Andrew Lunn wrote: > >>> On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: > When either the SP

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread kernel test robot
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1d

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread kernel test robot
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Fix-mixed-module-builtin-build/20210115-215024 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1d

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Heiner Kallweit
On 15.01.2021 16:59, Andrew Lunn wrote: > On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: >> On 1/15/21 4:00 PM, Andrew Lunn wrote: >>> On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: When either the SPI or PAR variant is compiled as module AND the other variant

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Marek Vasut
On 1/15/21 4:59 PM, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: On 1/15/21 4:00 PM, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: When either the SPI or PAR variant is compiled as module AND the other variant is compiled as

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Andrew Lunn
On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: > On 1/15/21 4:00 PM, Andrew Lunn wrote: > > On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: > > > When either the SPI or PAR variant is compiled as module AND the other > > > variant is compiled as built-in, the following bu

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Marek Vasut
On 1/15/21 4:00 PM, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Andrew Lunn
On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut wrote: > When either the SPI or PAR variant is compiled as module AND the other > variant is compiled as built-in, the following build error occurs: > > arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in > function `ks8851_p

[PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-15 Thread Marek Vasut
When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': ks8851_common.c:(.text+0x1564): undefined reference to `_