Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-13 Thread Philip Prindeville
> On Jun 11, 2016, at 12:02 AM, David Miller wrote: > > From: "Philip Prindeville" > Date: Tue, 7 Jun 2016 13:48:46 -0600 > >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block ICMP Unreachable >> (including Fragmentation Required) messages, Path MTU Discove

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-10 Thread David Miller
From: "Philip Prindeville" Date: Tue, 7 Jun 2016 13:48:46 -0600 > From: Philip Prindeville > > In the presence of firewalls which improperly block ICMP Unreachable > (including Fragmentation Required) messages, Path MTU Discovery is > prevented from working. > > A workaround is to handle IPv4

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
> On Jun 7, 2016, at 9:22 PM, Alexander Duyck wrote: > > On Tue, Jun 7, 2016 at 12:48 PM, Philip Prindeville > wrote: >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block ICMP Unreachable >> (including Fragmentation Required) messages, Path MTU Discovery is >>

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Alexander Duyck
On Tue, Jun 7, 2016 at 12:48 PM, Philip Prindeville wrote: > From: Philip Prindeville > > In the presence of firewalls which improperly block ICMP Unreachable > (including Fragmentation Required) messages, Path MTU Discovery is > prevented from working. > > A workaround is to handle IPv4 payloads

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 04:23 PM, Hannes Frederic Sowa wrote: On 07.06.2016 22:42, Philip Prindeville wrote: On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git a/net/ipv

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Hannes Frederic Sowa
On 07.06.2016 22:42, Philip Prindeville wrote: > On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: >> >> On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: >>> static struct rtnl_link_ops ipgre_link_ops __read_mostly = { >>> diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c >>> ind

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index d8f5e0a..95649eb 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Hannes Frederic Sowa
On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: > static struct rtnl_link_ops ipgre_link_ops __read_mostly = { > diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c > index d8f5e0a..95649eb 100644 > --- a/net/ipv4/ip_tunnel.c > +++ b/net/ipv4/ip_tunnel.c > @@ -682,7 +682,7 @@ void

[PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. A workaround is to handle IPv4 payloads opaquely, ignoring the DF bit--as is done for other payloads like Apple