RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
..@fb.com; > songliubrav...@fb.com; y...@fb.com; andr...@fb.com; > john.fastab...@gmail.com; kpsi...@chromium.org; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX > indirection table > > On Fri,

Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Stephen Hemminger
On Fri, 17 Jul 2020 09:55:35 -0700 (PDT) David Miller wrote: > From: Haiyang Zhang > Date: Fri, 17 Jul 2020 16:18:11 + > > > Also in some minimal installation, "ethtool" may not always be > > installed. > > This is never an argument against using the most well suited API for > exporting

RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
earbox.net; ka...@fb.com; songliubrav...@fb.com; > y...@fb.com; andr...@fb.com; john.fastab...@gmail.com; > kpsi...@chromium.org; linux-hyp...@vger.kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX > indirection table > > Fro

Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread David Miller
From: Haiyang Zhang Date: Fri, 17 Jul 2020 16:18:11 + > Also in some minimal installation, "ethtool" may not always be > installed. This is never an argument against using the most well suited API for exporting information to the user. You can write "minimal" tools that just perform the eth

RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
rtin KaFai Lau ; Song > Liu ; Yonghong Song ; Andrii Nakryiko > ; John Fastabend ; KP Singh > ; linux-hyp...@vger.kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX > indirection table > > On Fri, 17 Jul 2020 06:0

Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Stephen Hemminger
On Fri, 17 Jul 2020 06:04:31 + Chi Song wrote: > The network is observed with low performance, if TX indirection table is > imbalance. > But the table is in memory and set in runtime, it's hard to know. Add them to > attributes can help on troubleshooting. The receive indirection table co

Re: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Wei Liu
Hi Chi Thanks for your patch. A few things need to be fixed before it can be accepted upstream. On Fri, Jul 17, 2020 at 06:04:31AM +, Chi Song wrote: > The network is observed with low performance, if TX indirection table > is imbalance. But the table is in memory and set in runtime, it's >

[PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-16 Thread Chi Song
The network is observed with low performance, if TX indirection table is imbalance. But the table is in memory and set in runtime, it's hard to know. Add them to attributes can help on troubleshooting. --- drivers/net/hyperv/netvsc_drv.c | 46 + 1 file changed, 46