Re: [PATCH net-next] net: ethtool: add support for forward error correction modes

2017-02-11 Thread Vidya Chowdary
On Sat, Feb 11, 2017 at 5:33 AM, Mintz, Yuval wrote: >> +/** >> + * struct ethtool_fecparam - Ethernet forward error correction(fec) >> +parameters >> + * @cmd: Command number = %ETHTOOL_GFECPARAM or >> %ETHTOOL_SFECPARAM >> + * @active_fec: FEC mode which is active on porte >> + * @fec: Bitmask o

RE: [PATCH net-next] net: ethtool: add support for forward error correction modes

2017-02-11 Thread Mintz, Yuval
> +/** > + * struct ethtool_fecparam - Ethernet forward error correction(fec) > +parameters > + * @cmd: Command number = %ETHTOOL_GFECPARAM or > %ETHTOOL_SFECPARAM > + * @active_fec: FEC mode which is active on porte > + * @fec: Bitmask of supported/configured FEC modes > + * @rsvd: Reserved for fu

[PATCH net-next] net: ethtool: add support for forward error correction modes

2017-02-10 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FE

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-22 Thread Casey Leedom
I'm attempting to start the work necessary to implement Vidya's proposed new ethtool interface to manage Forward Error Correction settings on a link. I'm confused by the ethtool FEC API and the degree/type of control it offers. At the top of the patch we have: Encoding: Types of encoding Of

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-22 Thread Casey Leedom
And by the way, we currently have two ethtool APIs which pump in an Auto-Negotiation indication -- set_link_ksettings() and set_pauseparam(). Now we're talking about adding a third, set_fecparam(). Are all of the calls to these three APIs supposed to agree on the concept of Auto-Negotiations

[RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-11 Thread Casey Leedom
N.B. Sorry I'm not able to respond to the original message since I wasn't subscribed to netdev when it was sent a couple of weeks ago. This feature is something that Chelsio's cxgb4 driver needs. As we've tested our adapters against a number of switches, we've discovered a few which use varying d

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-08 Thread Vidya Sagar Ravipati
On Thu, Nov 3, 2016 at 6:24 AM, Gal Pressman wrote: > > > On 25/10/2016 05:50, Vidya Sagar Ravipati wrote: >> SET FEC option: >> root@tor: ethtool --set-fec swp1 encoding [off | RS | BaseR | auto] autoneg >> [off | on] >> >> Encoding: Types of encoding >> Off: Turning off any encoding >> RS

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-03 Thread Gal Pressman
On 25/10/2016 05:50, Vidya Sagar Ravipati wrote: > SET FEC option: > root@tor: ethtool --set-fec swp1 encoding [off | RS | BaseR | auto] autoneg > [off | on] > > Encoding: Types of encoding > Off: Turning off any encoding > RS : enforcing RS-FEC encoding on supported speeds > BaseR

[RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-10-24 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FE