On 06/21/2016 01:43 AM, Francois Romieu wrote:
> Netanel Belgazal :
> [...]
>>> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h
>>> b/drivers/net/ethernet/amazon/ena/ena_com.h
>>> new file mode 100644
>>> index 000..e49ba43
>>> --- /dev/null
>>> [...]
>>> +static inline void ena_com_
Netanel Belgazal :
[...]
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h
> > b/drivers/net/ethernet/amazon/ena/ena_com.h
> > new file mode 100644
> > index 000..e49ba43
> > --- /dev/null
> > [...]
> > +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg
> > *intr
On 06/18/2016 12:11 AM, Francois Romieu wrote:
> Netanel Belgazal :
> [...]
>
> More stuff below.
>
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c
>> b/drivers/net/ethernet/amazon/ena/ena_com.c
>> new file mode 100644
>> index 000..357e10f
>> --- /dev/null
>> +++ b/drivers/net/et
On 06/20/2016 08:20 AM, Rosen, Rami wrote:
> Hi all,
>
> A very limited review below.
>
> +
> + /* get capabilities of particular feature */
> + ENA_ADMIN_GET_FEATURE = 8,
>
> Instead /* get capabilities SHOULD BE: /* set capabilities .
> +
> + /* get capabilities of particular
On 06/17/2016 04:09 AM, Matt Wilson wrote:
> On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote:
>> Netanel Belgazal :
>> [...]
>>
>> Very limited review below.
> I'll comment on the documentation (since I edited it heavily) but will
> leave some the other parts for Netanel to answe
Hi all,
A very limited review below.
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_GET_FEATURE = 8,
Instead /* get capabilities SHOULD BE: /* set capabilities .
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_SET_FEATURE = 9,
+
..
+int
On Thu, Jun 16, 2016 at 07:06:52PM +0100, Ben Hutchings wrote:
> On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> > On 2016/06/13 11:46, Netanel Belgazal wrote:
> [...]
> > > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > > + struct device
Netanel Belgazal :
[...]
More stuff below.
> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c
> b/drivers/net/ethernet/amazon/ena/ena_com.c
> new file mode 100644
> index 000..357e10f
> --- /dev/null
> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
[...]
> +static int ena_get_dev_sta
On Thu, Jun 16, 2016 at 10:46:23PM +0200, Francois Romieu wrote:
> Netanel Belgazal :
> [...]
>
> Very limited review below.
I'll comment on the documentation (since I edited it heavily) but will
leave some the other parts for Netanel to answer.
> > diff --git a/Documentation/networking/ena.txt
Netanel Belgazal :
[...]
Very limited review below.
> diff --git a/Documentation/networking/ena.txt
> b/Documentation/networking/ena.txt
> new file mode 100644
> index 000..528544f
> --- /dev/null
> +++ b/Documentation/networking/ena.txt
> @@ -0,0 +1,330 @@
> +Linux kernel driver for Elasti
On Thu, 2016-06-16 at 10:55 -0700, Benjamin Poirier wrote:
> On 2016/06/13 11:46, Netanel Belgazal wrote:
[...]
> > +static ssize_t ena_show_small_copy_len(struct device *dev,
> > + struct device_attribute *attr, char *buf)
> > +{
> > + struct ena_adapter *adapter
On 2016/06/13 11:46, Netanel Belgazal wrote:
[...]
> +
> +static int ena_set_coalesce(struct net_device *net_dev,
> + struct ethtool_coalesce *coalesce)
> +{
> + struct ena_adapter *adapter = netdev_priv(net_dev);
> + struct ena_com_dev *ena_dev = adapter->ena_dev;
>
On Wed, Jun 15, 2016 at 09:32:35PM +0300, Netanel Belgazal wrote:
> I removed HAVE_NETDEV_NAPI_LIST and fixed the ena print macro.
> I'll wait a bit to see if there are additional comment before I'll send the
> v2 patch.
Also, please don't top post (reply inline) and send emails as plain
text only
On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote:
>
> You also had a few typos in the email addresses on the Cc: line that
> I've corrected (d...@avemeloft.net -> da...@davemeloft.net,
Argh, and of course I typo'ed the correction. -> da...@davemloft.net.
--msw
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal
[...]
> +
> +struct ena_napi {
> + struct napi_struct napi cacheline_aligned;
> + struct ena_ring *tx_ring;
On Tue, Jun 14, 2016 at 11:27:09PM -0700, David Miller wrote:
> From: Matt Wilson
> Date: Tue, 14 Jun 2016 23:23:36 -0700
>
> > Point taken, though existing drivers (even fairly popular ones) also
> > aren't as clean as you might like. A quick look around...
>
> Existing drivers do undesirable t
From: Matt Wilson
Date: Tue, 14 Jun 2016 23:23:36 -0700
> Point taken, though existing drivers (even fairly popular ones) also
> aren't as clean as you might like. A quick look around...
Existing drivers do undesirable things, film at 11...
Yet are never a reason to accept such things in new dr
On Tue, Jun 14, 2016 at 10:25:16PM -0700, David Miller wrote:
> From: Netanel Belgazal
> Date: Mon, 13 Jun 2016 11:46:13 +0300
>
> > +#define ena_trc_dbg(format, arg...) \
> > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg)
> > +#define ena_trc_info(format, arg...) \
> > + pr_info("[ENA_
From: Netanel Belgazal
Date: Mon, 13 Jun 2016 11:46:13 +0300
> +#define ena_trc_dbg(format, arg...) \
> + pr_debug("[ENA_COM: %s] " format, __func__, ##arg)
> +#define ena_trc_info(format, arg...) \
> + pr_info("[ENA_COM: %s] " format, __func__, ##arg)
> +#define ena_trc_warn(format, arg.
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
Reviewed-by: Matt Wilson
> Signed-off-by: Netanel Belgazal
> ---
> Documentation/networking/00-INDEX |2 +
> Documentation/networking/e
20 matches
Mail list logo
