Re: [PATCH net-next] net: dsa: mv88e6xxx: lookup switch name

2015-10-30 Thread Vivien Didelot
On Oct. Friday 30 (44) 09:52 PM, Andrew Lunn wrote: > On Fri, Oct 30, 2015 at 04:36:56PM -0400, Vivien Didelot wrote: > > All the mv88e6xxx drivers use the exact same code in their probe > > function to lookup the switch name given its ID. > > I did consider this before. But they are not exactly t

Re: [PATCH net-next] net: dsa: mv88e6xxx: lookup switch name

2015-10-30 Thread Andrew Lunn
On Fri, Oct 30, 2015 at 04:36:56PM -0400, Vivien Didelot wrote: > All the mv88e6xxx drivers use the exact same code in their probe > function to lookup the switch name given its ID. I did consider this before. But they are not exactly the same, when you consider the masking of the lower nibble whi

[PATCH net-next] net: dsa: mv88e6xxx: lookup switch name

2015-10-30 Thread Vivien Didelot
All the mv88e6xxx drivers use the exact same code in their probe function to lookup the switch name given its ID. Thus introduce a mv88e6xxx_switch_id structure and a mv88e6xxx_lookup_name function in the common mv88e6xxx code. In the meantime make __mv88e6xxx_reg_{read,write} static since they we