Re: [PATCH net-next] net: dsa: mv88e6xxx: check for mode change in port_setup_mac

2019-08-13 Thread Marek Behun
On Tue, 13 Aug 2019 22:32:34 +0200 Andrew Lunn wrote: > On Tue, Aug 13, 2019 at 07:12:43PM +0200, Marek Behún wrote: > > @@ -598,12 +599,49 @@ int mv88e6352_port_link_state(struct mv88e6xxx_chip > > *chip, int port, > > struct phylink_link_state *state) > > { > > i

Re: [PATCH net-next] net: dsa: mv88e6xxx: check for mode change in port_setup_mac

2019-08-13 Thread Andrew Lunn
On Tue, Aug 13, 2019 at 07:12:43PM +0200, Marek Behún wrote: > @@ -598,12 +599,49 @@ int mv88e6352_port_link_state(struct mv88e6xxx_chip > *chip, int port, > struct phylink_link_state *state) > { > int err; > - u16 reg; > + u16 reg, mac; > > err =

[PATCH net-next] net: dsa: mv88e6xxx: check for mode change in port_setup_mac

2019-08-13 Thread Marek Behún
The mv88e6xxx_port_setup_mac checks if the requested MAC settings are different from the current ones, and if not, does nothing (since chaning them requires putting the link down). In this check it only looks if the triplet [link, speed, duplex] is being changed. This patch adds support to also c