Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-19 Thread Florian Fainelli
On 9/19/19 2:30 PM, Jason Cobham wrote: > Hi Iwan, > >> Hi Andrew, >> >> I only own a simple 5 ports switch (88E6176) which has no problem of >> mirroring the other ports to a single port. Except for a bandwith shortage >> ofcourse. While I thought I checked adding and removing ports, I seemed t

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-19 Thread Jason Cobham
Hi Iwan, >Hi Andrew, > >I only own a simple 5 ports switch (88E6176) which has no problem of mirroring >the other ports to a single port. Except for a bandwith shortage ofcourse. >While I thought I checked adding and removing ports, I seemed to forgot to >check removing ingress traffic as it wi

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-17 Thread Florian Fainelli
On 9/17/19 3:32 PM, Iwan R Timmer wrote: > On Tue, Sep 17, 2019 at 10:55:05PM +0200, Andrew Lunn wrote: >> On Tue, Sep 17, 2019 at 10:23:01PM +0200, Iwan R Timmer wrote: >>> Add support for configuring port mirroring through the cls_matchall >>> classifier. We do a full ingress and/or egress captur

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-17 Thread Iwan R Timmer
On Tue, Sep 17, 2019 at 10:55:05PM +0200, Andrew Lunn wrote: > On Tue, Sep 17, 2019 at 10:23:01PM +0200, Iwan R Timmer wrote: > > Add support for configuring port mirroring through the cls_matchall > > classifier. We do a full ingress and/or egress capture towards the > > capture port, configured w

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-17 Thread Andrew Lunn
On Tue, Sep 17, 2019 at 10:23:01PM +0200, Iwan R Timmer wrote: > Add support for configuring port mirroring through the cls_matchall > classifier. We do a full ingress and/or egress capture towards the > capture port, configured with set_egress_port. Hi Iwan This looks good as far as it goes. Ha

[PATCH net-next] net: dsa: mv88e6xxx: Add support for port mirroring

2019-09-17 Thread Iwan R Timmer
Add support for configuring port mirroring through the cls_matchall classifier. We do a full ingress and/or egress capture towards the capture port, configured with set_egress_port. Signed-off-by: Iwan R Timmer --- drivers/net/dsa/mv88e6xxx/chip.c | 36 drivers/n