Re: [PATCH net-next] net: dsa: mv88e6xxx: Add serdes read/write dynamic debug

2020-07-09 Thread Andrew Lunn
On Thu, Jul 09, 2020 at 11:43:18AM -0700, Chris Healy wrote: > Add deb_dbg print statements in both serdes_read and serdes_write > functions. Hi Chris Why is SERDES access special? Why not all accesses? global1, global2, global3, port, etc. As David said, tracepoints are better for this. Take a

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add serdes read/write dynamic debug

2020-07-09 Thread David Miller
From: Chris Healy Date: Thu, 9 Jul 2020 11:43:18 -0700 > Add deb_dbg print statements in both serdes_read and serdes_write > functions. > > Signed-off-by: Chris Healy Please just use tracepoints or similar for this.

[PATCH net-next] net: dsa: mv88e6xxx: Add serdes read/write dynamic debug

2020-07-09 Thread Chris Healy
Add deb_dbg print statements in both serdes_read and serdes_write functions. Signed-off-by: Chris Healy --- drivers/net/dsa/mv88e6xxx/serdes.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv