Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
On 9/30/2020 4:29 PM, Florian Fainelli wrote: On 9/30/2020 1:43 PM, Vladimir Oltean wrote: On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote: While we are it, call __vlan_find_dev_deep_rcu() which makes use the VLAN group array which is faster. Not just "while at it", but

Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
On 9/30/2020 1:43 PM, Vladimir Oltean wrote: On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote: While we are it, call __vlan_find_dev_deep_rcu() which makes use the VLAN group array which is faster. Not just "while at it", but I do wonder whether it isn't, in fact, called "de

Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Vladimir Oltean
On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote: > While we are it, call __vlan_find_dev_deep_rcu() which makes use the > VLAN group array which is faster. Not just "while at it", but I do wonder whether it isn't, in fact, called "deep" for a reason: /*

[PATCH net-next] net: dsa: Support bridge 802.1Q while untagging

2020-09-30 Thread Florian Fainelli
The intent of 412a1526d067 ("net: dsa: untag the bridge pvid from rx skbs") is to transparently untag the bridge's default_pvid when the Ethernet switch can only support egress tagged of that default_pvid towards the CPU port. Prior to this commit, users would have to configure an 802.1Q upper on