Re: [PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-11-02 Thread Andrew Lunn
On Mon, Nov 02, 2020 at 02:55:03PM -0500, Jeffrey Layton wrote: > On Wed, Oct 28, 2020 at 01:59:07AM +0100, Andrew Lunn wrote: > > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid' > > not described in 'ceph_cls_break_lock' > > net/ceph/cls_lock_client.c:143: warning: Fun

Re: [PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-11-02 Thread Jeffrey Layton
On Wed, Oct 28, 2020 at 01:59:07AM +0100, Andrew Lunn wrote: > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid' > not described in 'ceph_cls_break_lock' > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oloc' > not described in 'ceph_cls_break_loc

Re: [PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-10-28 Thread Jakub Kicinski
On Wed, 28 Oct 2020 01:59:07 +0100 Andrew Lunn wrote: > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid' > not described in 'ceph_cls_break_lock' > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oloc' > not described in 'ceph_cls_break_lock' > ..

Re: [PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-10-28 Thread Andrew Lunn
On Tue, Oct 27, 2020 at 06:09:08PM -0700, Jakub Kicinski wrote: > On Wed, 28 Oct 2020 01:59:07 +0100 Andrew Lunn wrote: > > net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid' > > not described in 'ceph_cls_break_lock' > > net/ceph/cls_lock_client.c:143: warning: Function p

[PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-10-28 Thread Andrew Lunn
net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oid' not described in 'ceph_cls_break_lock' net/ceph/cls_lock_client.c:143: warning: Function parameter or member 'oloc' not described in 'ceph_cls_break_lock' net/ceph/cls_lock_client.c:143: warning: Function parameter or mem

Re: [PATCH net-next] net: ceph: Fix most of the kerneldoc warings

2020-10-28 Thread Andrew Lunn
As the subject suggests, there is still one warning left: net/ceph/crush/mapper.c:674: warning: Function parameter or member 'left' not described in 'crush_choose_indep' It would be nice if somebody who understands this code could fix that warning. Then ceph become W=1 clean. Andrew