Re: [PATCH net-next] net: bcmgenet: Remove checks on clock handles

2015-07-26 Thread David Miller
From: Florian Fainelli Date: Wed, 22 Jul 2015 15:11:54 -0700 > Instead of multiplying the number of checks for IS_ERR(priv->clk), > simply NULLify the 'struct clk' pointer which is something the Linux > common clock framework perfectly deals with and does early return for > each and every single

Re: [PATCH net-next] net: bcmgenet: Remove checks on clock handles

2015-07-22 Thread Florian Fainelli
On 22/07/15 16:52, Petri Gynther wrote: > On Wed, Jul 22, 2015 at 3:11 PM, Florian Fainelli > wrote: >> >> Instead of multiplying the number of checks for IS_ERR(priv->clk), >> simply NULLify the 'struct clk' pointer which is something the Linux >> common clock framework perfectly deals with and

Re: [PATCH net-next] net: bcmgenet: Remove checks on clock handles

2015-07-22 Thread Petri Gynther
On Wed, Jul 22, 2015 at 3:11 PM, Florian Fainelli wrote: > > Instead of multiplying the number of checks for IS_ERR(priv->clk), > simply NULLify the 'struct clk' pointer which is something the Linux > common clock framework perfectly deals with and does early return for > each and every single clk

[PATCH net-next] net: bcmgenet: Remove checks on clock handles

2015-07-22 Thread Florian Fainelli
Instead of multiplying the number of checks for IS_ERR(priv->clk), simply NULLify the 'struct clk' pointer which is something the Linux common clock framework perfectly deals with and does early return for each and every single clk_* API functions. Having every single function check for !IS_ERR(pr