Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-09-08 Thread David Miller
From: David Ahern Date: Mon, 31 Aug 2015 14:44:46 -0600 > If anything I should be going straight to fib_table_lookup in the VRF > driver for this new lookup to get the source address. It knows the > exact table that should be used and hence can avoid the rules walk + > local table miss which happ

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Ahern
On 8/31/15 1:44 PM, David Miller wrote: From: David Ahern Date: Mon, 31 Aug 2015 09:29:40 -0700 Remove the VRF change in udp_sendmsg to set the source address. The VRF driver already has access to the packet on the TX path via the dst. It can be used to update the source address in the header.

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Miller
From: David Ahern Date: Mon, 31 Aug 2015 09:29:40 -0700 > Remove the VRF change in udp_sendmsg to set the source address. The VRF > driver already has access to the packet on the TX path via the dst. It > can be used to update the source address in the header. > > Update function based on OVS. >

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 10:40 AM, David Ahern wrote: > Hi Tom: > > On 8/31/15 11:22 AM, Tom Herbert wrote: >> >> It's a major departure from current convention. The source address of >> the packet should be set before doing ip_send_skb. In UDP unconnected >> case ip_route_output_flow calls inet_se

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Ahern
On 8/31/15 11:22 AM, Tom Herbert wrote: It's a major departure from current convention. The source address of the packet should be set before doing ip_send_skb. In UDP unconnected case ip_route_output_flow calls inet_select_addr. AKAIK there is no provision for not setting the source address and

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Ahern
Hi Tom: On 8/31/15 11:22 AM, Tom Herbert wrote: It's a major departure from current convention. The source address of the packet should be set before doing ip_send_skb. In UDP unconnected case ip_route_output_flow calls inet_select_addr. AKAIK there is no provision for not setting the source add

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 10:05 AM, David Ahern wrote: > On 8/31/15 11:02 AM, Tom Herbert wrote: >> >> On Mon, Aug 31, 2015 at 9:29 AM, David Ahern >> wrote: >>> >>> Remove the VRF change in udp_sendmsg to set the source address. The VRF >>> driver already has access to the packet on the TX path vi

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Ahern
On 8/31/15 11:02 AM, Tom Herbert wrote: On Mon, Aug 31, 2015 at 9:29 AM, David Ahern wrote: Remove the VRF change in udp_sendmsg to set the source address. The VRF driver already has access to the packet on the TX path via the dst. It can be used to update the source address in the header. I

Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread Tom Herbert
On Mon, Aug 31, 2015 at 9:29 AM, David Ahern wrote: > Remove the VRF change in udp_sendmsg to set the source address. The VRF > driver already has access to the packet on the TX path via the dst. It > can be used to update the source address in the header. > I don't understand this. The previous

[PATCH net-next] net: Remove VRF change to udp_sendmsg

2015-08-31 Thread David Ahern
Remove the VRF change in udp_sendmsg to set the source address. The VRF driver already has access to the packet on the TX path via the dst. It can be used to update the source address in the header. Update function based on OVS. Cc: Tom Herbert Signed-off-by: David Ahern --- drivers/net/vrf.c