Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-21 Thread Jesper Dangaard Brouer
On Thu, 20 Dec 2018 14:11:35 -0800 "Jonathan Lemon" wrote: > On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: > [...] > > I don't like adding this in the hot-path. Instead we could move this > > to the page alloc slow-path, and reject allocating pages with > > pgmemalloc in the first pl

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Saeed Mahameed
On Fri, 2018-12-21 at 02:13 +, Saeed Mahameed wrote: > On Thu, 2018-12-20 at 16:56 -0800, Jonathan Lemon wrote: > > On 20 Dec 2018, at 15:41, Saeed Mahameed wrote: > > > > > On Thu, 2018-12-20 at 14:11 -0800, Jonathan Lemon wrote: > > > > (Resending due to mailer issues) > > > > > > > > On 20

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Saeed Mahameed
On Thu, 2018-12-20 at 16:56 -0800, Jonathan Lemon wrote: > On 20 Dec 2018, at 15:41, Saeed Mahameed wrote: > > > On Thu, 2018-12-20 at 14:11 -0800, Jonathan Lemon wrote: > > > (Resending due to mailer issues) > > > > > > On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: > > > > > > > On Wed

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Jonathan Lemon
On 20 Dec 2018, at 15:41, Saeed Mahameed wrote: > On Thu, 2018-12-20 at 14:11 -0800, Jonathan Lemon wrote: >> (Resending due to mailer issues) >> >> On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: >> >>> On Wed, 19 Dec 2018 12:06:51 -0800 >>> Jonathan Lemon wrote: >>> Return pfmemallo

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Saeed Mahameed
On Thu, 2018-12-20 at 14:11 -0800, Jonathan Lemon wrote: > (Resending due to mailer issues) > > On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: > > > On Wed, 19 Dec 2018 12:06:51 -0800 > > Jonathan Lemon wrote: > > > > > Return pfmemalloc pages back to the page allocator, instead of > >

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Jonathan Lemon
(Resending due to mailer issues) On 20 Dec 2018, at 5:03, Jesper Dangaard Brouer wrote: On Wed, 19 Dec 2018 12:06:51 -0800 Jonathan Lemon wrote: Return pfmemalloc pages back to the page allocator, instead of holding them in the page pool. Have you experience this issue in practice or is it

Re: [PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-20 Thread Jesper Dangaard Brouer
On Wed, 19 Dec 2018 12:06:51 -0800 Jonathan Lemon wrote: > Return pfmemalloc pages back to the page allocator, instead of > holding them in the page pool. Have you experience this issue in practice or is it theory? > While here, also use the __page_pool_return_page() API. Don't combine severa

[PATCH net-next] net: Don't return pfmemalloc pages to the page pool.

2018-12-19 Thread Jonathan Lemon
Return pfmemalloc pages back to the page allocator, instead of holding them in the page pool. While here, also use the __page_pool_return_page() API. Signed-off-by: Jonathan Lemon --- net/core/page_pool.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/core/page_poo