Re: [PATCH net-next] net: Avoid spurious rx_dropped increases with tap and rx_handler

2020-05-25 Thread David Miller
From: Benjamin Poirier Date: Mon, 25 May 2020 14:01:37 +0900 > Consider an skb which doesn't match a ptype_base/ptype_specific handler. If > this skb is delivered to a ptype_all handler, it does not count as a drop. > However, if the skb is also processed by an rx_handler which returns > RX_HANDL

Re: [PATCH net-next] net: Avoid spurious rx_dropped increases with tap and rx_handler

2020-05-25 Thread Benjamin Poirier
On 2020-05-24 22:41 -0700, Eric Dumazet wrote: > On Sun, May 24, 2020 at 10:02 PM Benjamin Poirier > wrote: > > > > Consider an skb which doesn't match a ptype_base/ptype_specific handler. If > > this skb is delivered to a ptype_all handler, it does not count as a drop. > > However, if the skb is

[PATCH net-next] net: Avoid spurious rx_dropped increases with tap and rx_handler

2020-05-24 Thread Benjamin Poirier
Consider an skb which doesn't match a ptype_base/ptype_specific handler. If this skb is delivered to a ptype_all handler, it does not count as a drop. However, if the skb is also processed by an rx_handler which returns RX_HANDLER_PASS, the frame is now counted as a drop because pt_prev was reset.