Re: [PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 09:35:03 +0200 Eric Dumazet wrote: > On Fri, Oct 9, 2020 at 2:18 AM Jakub Kicinski wrote: > > > > On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote: > > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > > > index > > > 6c762457122fd0091cb0f2bf41bda73b

Re: [PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-08 Thread Jakub Kicinski
On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote: > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index > 6c762457122fd0091cb0f2bf41bda73babc4ac12..d8fd8676fc724110630904909f64d7789f3a4b47 > 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @

Re: [PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-07 Thread Cong Wang
On Wed, Oct 7, 2020 at 9:51 AM Eric Dumazet wrote: > > From: Eric Dumazet > > kmalloc() of sufficiently big portion of memory is cache-aligned > in regular conditions. If some debugging options are used, > there is no reason qdisc structures would need 64-byte alignment > if most other kernel str

[PATCH net-next] net/sched: get rid of qdisc->padded

2020-10-07 Thread Eric Dumazet
From: Eric Dumazet kmalloc() of sufficiently big portion of memory is cache-aligned in regular conditions. If some debugging options are used, there is no reason qdisc structures would need 64-byte alignment if most other kernel structures are not aligned. This get rid of QDISC_ALIGN and QDISC_A