Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-15 Thread David Miller
From: Hadar Hen Zion Date: Mon, 12 Sep 2016 15:19:21 +0300 > Remove rcu_read_lock protection from tunnel_key_dump and use > rtnl_dereference, dump operation is protected by rtnl lock. > > Also, remove rcu_read_lock from tunnel_key_release and use > rcu_dereference_protected. > > Both operation

Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-12 Thread Eric Dumazet
On Mon, 2016-09-12 at 07:09 -0700, John Fastabend wrote: > On 16-09-12 05:19 AM, Hadar Hen Zion wrote: > > Remove rcu_read_lock protection from tunnel_key_dump and use > > rtnl_dereference, dump operation is protected by rtnl lock. > > > > Also, remove rcu_read_lock from tunnel_key_release and us

Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-12 Thread John Fastabend
On 16-09-12 05:19 AM, Hadar Hen Zion wrote: > Remove rcu_read_lock protection from tunnel_key_dump and use > rtnl_dereference, dump operation is protected by rtnl lock. > > Also, remove rcu_read_lock from tunnel_key_release and use > rcu_dereference_protected. > > Both operations are running exc

[PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read_lock protection

2016-09-12 Thread Hadar Hen Zion
Remove rcu_read_lock protection from tunnel_key_dump and use rtnl_dereference, dump operation is protected by rtnl lock. Also, remove rcu_read_lock from tunnel_key_release and use rcu_dereference_protected. Both operations are running exclusively and a writer couldn't modify t->params while thos