Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-04 Thread Eric Dumazet
On 05/04/2018 08:59 AM, David Miller wrote: > > No need to extra round-trip, I applied it directly ;) > Very nice, thanks David !

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-04 Thread David Miller
From: Eric Dumazet Date: Thu, 3 May 2018 19:10:29 -0700 > > > On 05/03/2018 06:52 PM, David Miller wrote: >> From: Eric Dumazet >> Date: Thu, 3 May 2018 17:05:06 -0700 >> >>> >>> >>> On 05/02/2018 07:18 AM, Tariq Toukan wrote: On 27/04/2018 1:56 AM, Saeed Mahameed wrote: >>> >>

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-03 Thread Eric Dumazet
On 05/03/2018 06:52 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 3 May 2018 17:05:06 -0700 > >> >> >> On 05/02/2018 07:18 AM, Tariq Toukan wrote: >>> >>> >>> On 27/04/2018 1:56 AM, Saeed Mahameed wrote: >> LGTM, Reviewed-by: Saeed Mahameed >>> >>> Acked-by: Tar

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-03 Thread David Miller
From: Eric Dumazet Date: Thu, 3 May 2018 17:05:06 -0700 > > > On 05/02/2018 07:18 AM, Tariq Toukan wrote: >> >> >> On 27/04/2018 1:56 AM, Saeed Mahameed wrote: > >>> LGTM, >>> >>> Reviewed-by: Saeed Mahameed >>> >> >> Acked-by: Tariq Toukan >> >> Thanks Eric. > > Thanks guys. > > I se

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-03 Thread Eric Dumazet
On 05/02/2018 07:18 AM, Tariq Toukan wrote: > > > On 27/04/2018 1:56 AM, Saeed Mahameed wrote: >> LGTM, >> >> Reviewed-by: Saeed Mahameed >> > > Acked-by: Tariq Toukan > > Thanks Eric. Thanks guys. I see this patch ( http://patchwork.ozlabs.org/patch/901336/ ) in a state I do not know

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-05-02 Thread Tariq Toukan
On 27/04/2018 1:56 AM, Saeed Mahameed wrote: On Thu, 2018-04-19 at 08:49 -0700, Eric Dumazet wrote: While trying to support CHECKSUM_COMPLETE for IPV6 fragments, I had to experiments various hacks in get_fixed_ipv6_csum(). I must admit I could not find how to implement this :/ However, get_fi

Re: [PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-04-26 Thread Saeed Mahameed
On Thu, 2018-04-19 at 08:49 -0700, Eric Dumazet wrote: > While trying to support CHECKSUM_COMPLETE for IPV6 fragments, > I had to experiments various hacks in get_fixed_ipv6_csum(). > I must admit I could not find how to implement this :/ > > However, get_fixed_ipv6_csum() does a lot of redundant

[PATCH net-next] net/mlx4_en: optimizes get_fixed_ipv6_csum()

2018-04-19 Thread Eric Dumazet
While trying to support CHECKSUM_COMPLETE for IPV6 fragments, I had to experiments various hacks in get_fixed_ipv6_csum(). I must admit I could not find how to implement this :/ However, get_fixed_ipv6_csum() does a lot of redundant operations, calling csum_partial() twice. First csum_partial() c