Re: [PATCH net-next] mvpp2: fix pointer check

2020-07-07 Thread David Miller
From: Matteo Croce Date: Tue, 7 Jul 2020 15:19:13 +0200 > From: Matteo Croce > > priv->page_pool is an array, so comparing against it will always return true. > Do a meaningful check by checking priv->page_pool[0] instead. > While at it, clear the page_pool pointers on deallocation, or when an

[PATCH net-next] mvpp2: fix pointer check

2020-07-07 Thread Matteo Croce
From: Matteo Croce priv->page_pool is an array, so comparing against it will always return true. Do a meaningful check by checking priv->page_pool[0] instead. While at it, clear the page_pool pointers on deallocation, or when an allocation error happens during init. Reported-by: Colin Ian King