Re: [PATCH net-next] mptcp: put reference in mptcp timeout timer

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 17:42:21 +0100 Paolo Abeni wrote: > On Tue, 2020-11-24 at 17:24 +0100, Florian Westphal wrote: > > On close this timer might be scheduled. mptcp uses sk_reset_timer for > > this, so the a reference on the mptcp socket is taken. > > > > This causes a refcount leak which can for

Re: [PATCH net-next] mptcp: put reference in mptcp timeout timer

2020-11-24 Thread Paolo Abeni
On Tue, 2020-11-24 at 17:24 +0100, Florian Westphal wrote: > On close this timer might be scheduled. mptcp uses sk_reset_timer for > this, so the a reference on the mptcp socket is taken. > > This causes a refcount leak which can for example be reproduced > with 'mp_join_server_v4.pkt' from the mp

[PATCH net-next] mptcp: put reference in mptcp timeout timer

2020-11-24 Thread Florian Westphal
On close this timer might be scheduled. mptcp uses sk_reset_timer for this, so the a reference on the mptcp socket is taken. This causes a refcount leak which can for example be reproduced with 'mp_join_server_v4.pkt' from the mptcp-packetdrill repo. The leak has nothing to do with join requests,