Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-24 Thread Petr Machata
Ido Schimmel writes: > On Mon, Sep 24, 2018 at 12:04:17AM +0200, Andrew Lunn wrote: >> But doesn't that mean you reflash the device with the minimum version, >> when in fact there could be a much newer version in /lib/firmware? > > No, because we always enforce the latest version we post to > lin

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
On Mon, Sep 24, 2018 at 12:04:17AM +0200, Andrew Lunn wrote: > On Mon, Sep 24, 2018 at 12:51:00AM +0300, Ido Schimmel wrote: > > On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > > > Therefore tweak the check to accept any FW version that is: > > > > > > > > - on the same branch as

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Andrew Lunn
On Mon, Sep 24, 2018 at 12:51:00AM +0300, Ido Schimmel wrote: > On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > > Therefore tweak the check to accept any FW version that is: > > > > > > - on the same branch as the preferred version, and > > > - the same as or newer than the prefer

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > Therefore tweak the check to accept any FW version that is: > > > > - on the same branch as the preferred version, and > > - the same as or newer than the preferred version. > > Hi Ido > > Do you print this information out? If the

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Andrew Lunn
> Therefore tweak the check to accept any FW version that is: > > - on the same branch as the preferred version, and > - the same as or newer than the preferred version. Hi Ido Do you print this information out? If the check fails, it would be useful to know what the minimal version is.

[PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
From: Petr Machata Up until now, mlxsw tolerated firmware versions that weren't exactly matching the required version, if the branch number matched. That allowed the users to test various firmware versions as long as they were on the right branch. On the other hand, it made it impossible for mlx