Re: [PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-19 Thread David Miller
From: Eric Dumazet Date: Tue, 17 Jan 2017 20:14:10 -0800 > From: Eric Dumazet > > Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX > ring with __GFP_NOMEMALLOC") added code that appears to be not needed at > that time, since mlx4 never used __GFP_MEMALLOC allocations anyway.

Re: [PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 18:11 +0300, Konstantin Khlebnikov wrote: > On 18.01.2017 17:23, Eric Dumazet wrote: > > > > Take a look at sk_filter_trim_cap(), where the RX packets received on a > > socket which does not have SOCK_MEMALLOC is dropped. > > > > /* > > * If the skb was alloc

Re: [PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-18 Thread Konstantin Khlebnikov
On 18.01.2017 17:23, Eric Dumazet wrote: On Wed, 2017-01-18 at 12:31 +0300, Konstantin Khlebnikov wrote: On 18.01.2017 07:14, Eric Dumazet wrote: From: Eric Dumazet Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC") added code that appears to be

Re: [PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-18 Thread Eric Dumazet
On Wed, 2017-01-18 at 12:31 +0300, Konstantin Khlebnikov wrote: > On 18.01.2017 07:14, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX > > ring with __GFP_NOMEMALLOC") added code that appears to be not needed at > > that time,

Re: [PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-18 Thread Konstantin Khlebnikov
On 18.01.2017 07:14, Eric Dumazet wrote: From: Eric Dumazet Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC") added code that appears to be not needed at that time, since mlx4 never used __GFP_MEMALLOC allocations anyway. As using memory reserves

[PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-17 Thread Eric Dumazet
From: Eric Dumazet Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC") added code that appears to be not needed at that time, since mlx4 never used __GFP_MEMALLOC allocations anyway. As using memory reserves is a must in some situations (swap over NF