Re: [PATCH net-next] mlx4: avoid unnecessary dirtying of critical fields

2016-11-20 Thread Eric Dumazet
On Sun, 2016-11-20 at 17:14 +0200, Tariq Toukan wrote: > Hi Eric, > > Thanks for your patch. > > On 18/11/2016 10:15 PM, Eric Dumazet wrote: > > + > > + AVG_PERF_COUNTER(priv->pstats.rx_coal_avg, polled); > Keep this perf stats update out of the if block. This perf stat would be useles

Re: [PATCH net-next] mlx4: avoid unnecessary dirtying of critical fields

2016-11-20 Thread Tariq Toukan
Hi Eric, Thanks for your patch. On 18/11/2016 10:15 PM, Eric Dumazet wrote: From: Eric Dumazet While stressing a 40Gbit mlx4 NIC with busy polling, I found false sharing in mlx4 driver that can be easily avoided. This patch brings an additional 7 % performance improvement in UDP_RR workload.

[PATCH net-next] mlx4: avoid unnecessary dirtying of critical fields

2016-11-18 Thread Eric Dumazet
From: Eric Dumazet While stressing a 40Gbit mlx4 NIC with busy polling, I found false sharing in mlx4 driver that can be easily avoided. This patch brings an additional 7 % performance improvement in UDP_RR workload. 1) If we received no frame during one mlx4_en_process_rx_cq() invocation, n