Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 07:33 PM, Craig Gallek wrote: On Wed, Sep 27, 2017 at 6:03 PM, Daniel Borkmann wrote: On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek [...] yes it will break loading of pre-compiled .o Instead of breaking, let's fi

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-28 Thread Craig Gallek
On Wed, Sep 27, 2017 at 6:03 PM, Daniel Borkmann wrote: > On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: >> >> On 9/27/17 7:04 AM, Craig Gallek wrote: >>> >>> From: Craig Gallek >>> >>> This extends struct bpf_map_def to include a flags field. Note that >>> this has the potential to break the

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-27 Thread Daniel Borkmann
On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek This extends struct bpf_map_def to include a flags field. Note that this has the potential to break the validation logic in bpf_object__validate_maps and bpf_object__init_maps as they

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-27 Thread Alexei Starovoitov
On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek This extends struct bpf_map_def to include a flags field. Note that this has the potential to break the validation logic in bpf_object__validate_maps and bpf_object__init_maps as they use sizeof(struct bpf_map_def) as a minimal allowab

[PATCH net-next] libbpf: use map_flags when creating maps

2017-09-27 Thread Craig Gallek
From: Craig Gallek This extends struct bpf_map_def to include a flags field. Note that this has the potential to break the validation logic in bpf_object__validate_maps and bpf_object__init_maps as they use sizeof(struct bpf_map_def) as a minimal allowable size of a map section. Any bpf program