Re: [PATCH net-next] lib8390: Use eth_skb_pad()

2020-11-14 Thread Florian Fainelli
On 11/12/2020 8:31 AM, Armin Wolf wrote: > Use eth_skb_pad() instead of a custom padding solution > and replace associated variables with skb->* expressions. > > Signed-off-by: Armin Wolf > --- [snip] > @@ -407,8 +404,8 @@ static netdev_tx_t __ei_start_xmit(struct sk_buff *skb, > spin_

Re: [PATCH net-next] lib8390: Use eth_skb_pad()

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 17:31:34 +0100 Armin Wolf wrote: > Use eth_skb_pad() instead of a custom padding solution > and replace associated variables with skb->* expressions. These are two separate changes, please split them out to two patches.

[PATCH net-next] lib8390: Use eth_skb_pad()

2020-11-12 Thread Armin Wolf
Use eth_skb_pad() instead of a custom padding solution and replace associated variables with skb->* expressions. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/lib8390.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/