Re: [PATCH net-next] lib8390: Replace panic() call with BUILD_BUG_ON

2020-09-28 Thread David Miller
From: Armin Wolf Date: Sun, 27 Sep 2020 21:56:59 +0200 > Replace panic() call in lib8390.c with BUILD_BUG_ON() > since checking the size of struct e8390_pkt_hdr should > happen at compile-time. Also add __packed to e8390_pkt_hdr > to prevent padding. > > Signed-off-by: Armin Wolf > --- > drive

[PATCH net-next] lib8390: Replace panic() call with BUILD_BUG_ON

2020-09-27 Thread Armin Wolf
Replace panic() call in lib8390.c with BUILD_BUG_ON() since checking the size of struct e8390_pkt_hdr should happen at compile-time. Also add __packed to e8390_pkt_hdr to prevent padding. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/8390.h| 2 +- drivers/net/ethernet/8390/lib8390.