Re: [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc()

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 07:34:14 -0700 Eric Dumazet wrote: > We currently have to adjust ipv6 route gc_thresh/max_size depending > on number of cpus on a server, this makes very little sense. > > If the kernels sets /proc/sys/net/ipv6/route/gc_thresh to 1024 > and /proc/sys/net/ipv6/route/max_size to

Re: [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc()

2020-05-08 Thread David Ahern
On 5/8/20 8:43 AM, Eric Dumazet wrote: > This patch can be backported without any pains ;) sure, but you tagged it as net-next, not net. > > Getting rid of limits, even for exceptions ? Running through where dst entries are created in IPv6: 1. pcpu cache 2. uncached_list 3. exceptions like pmtu

Re: [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc()

2020-05-08 Thread Eric Dumazet
On 5/8/20 7:39 AM, David Ahern wrote: > On 5/8/20 8:34 AM, Eric Dumazet wrote: >> We currently have to adjust ipv6 route gc_thresh/max_size depending >> on number of cpus on a server, this makes very little sense. >> >> If the kernels sets /proc/sys/net/ipv6/route/gc_thresh to 1024 >> and /proc/

Re: [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc()

2020-05-08 Thread David Ahern
On 5/8/20 8:34 AM, Eric Dumazet wrote: > We currently have to adjust ipv6 route gc_thresh/max_size depending > on number of cpus on a server, this makes very little sense. > > If the kernels sets /proc/sys/net/ipv6/route/gc_thresh to 1024 > and /proc/sys/net/ipv6/route/max_size to 4096, then we be