Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Wolfgang Walter
Am Mittwoch, 4. November 2015, 07:13:07 schrieb Eric Dumazet: > On Wed, 2015-11-04 at 15:09 +0100, Wolfgang Walter wrote: > > Yes, maybe igb has a problem sending a gro-packet if it is an isatap in > > gre. > We might detect this condition properly from igb ndo_features_check > method. > > It curr

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Eric Dumazet
On Wed, 2015-11-04 at 15:09 +0100, Wolfgang Walter wrote: > > Yes, maybe igb has a problem sending a gro-packet if it is an isatap in gre. We might detect this condition properly from igb ndo_features_check method. It currently uses plain passthru_features_check() > > igb has no problem sen

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Wolfgang Walter
Am Mittwoch, 4. November 2015, 04:40:51 schrieb Eric Dumazet: > On Wed, 2015-11-04 at 13:19 +0100, Wolfgang Walter wrote: > > Today I found a problem: on a router forwarding GRE-packets (ipv4) (it is > > not the endpount) the interface (intel igb) stops sending packets after > > some time. I think

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Eric Dumazet
On Wed, 2015-11-04 at 13:19 +0100, Wolfgang Walter wrote: > Today I found a problem: on a router forwarding GRE-packets (ipv4) (it is not > the endpount) the interface (intel igb) stops sending packets after some > time. > I think this happens when an ISATAP packet is inside the GRE-packet. >

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-04 Thread Wolfgang Walter
Am Dienstag, 3. November 2015, 05:07:33 schrieb Eric Dumazet: > On Tue, 2015-11-03 at 13:57 +0100, Wolfgang Walter wrote: > > Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet: > > > From: Eric Dumazet > > > > > > Tom Herbert added SIT support to GRO with commit > > > 19424e052fb4 ("sit:

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-03 Thread Tom Herbert
On Tue, Nov 3, 2015 at 10:07 PM, Eric Dumazet wrote: > On Tue, 2015-11-03 at 13:57 +0100, Wolfgang Walter wrote: >> Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet: >> > From: Eric Dumazet >> > >> > Tom Herbert added SIT support to GRO with commit >> > 19424e052fb4 ("sit: Add gro callb

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-03 Thread Eric Dumazet
On Tue, 2015-11-03 at 13:57 +0100, Wolfgang Walter wrote: > Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet: > > From: Eric Dumazet > > > > Tom Herbert added SIT support to GRO with commit > > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > > later reverted by Herbert Xu. > >

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-11-03 Thread Wolfgang Walter
Am Montag, 19. Oktober 2015, 20:40:17 schrieb Eric Dumazet: > From: Eric Dumazet > > Tom Herbert added SIT support to GRO with commit > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > later reverted by Herbert Xu. > > The problem came because Tom patch was building GRO > packets withou

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-10-21 Thread David Miller
From: Eric Dumazet Date: Mon, 19 Oct 2015 20:40:17 -0700 > From: Eric Dumazet > > Tom Herbert added SIT support to GRO with commit > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > later reverted by Herbert Xu. > > The problem came because Tom patch was building GRO > packets without

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-10-19 Thread Tom Herbert
On Mon, Oct 19, 2015 at 8:40 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Tom Herbert added SIT support to GRO with commit > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > later reverted by Herbert Xu. > > The problem came because Tom patch was building GRO > packets without proper

[PATCH net-next] ipv6: gro: support sit protocol

2015-10-19 Thread Eric Dumazet
From: Eric Dumazet Tom Herbert added SIT support to GRO with commit 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), later reverted by Herbert Xu. The problem came because Tom patch was building GRO packets without proper meta data : If packets were locally delivered, we would not care.