Re: [PATCH net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-21 Thread David Ahern
On 6/20/19 5:43 PM, Wei Wang wrote: > I am not very convinced that fib6_lookup() could be equivalent to > rt6_lookup(). Specifically, rt6_lookup() calls rt6_device_match() > while fib6_lookup() calls rt6_select() to match the oif. From a brief > glance, it does seem to be similar, especially consid

Re: [PATCH net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-20 Thread David Ahern
On 6/20/19 5:43 PM, Wei Wang wrote: > I am not very convinced that fib6_lookup() could be equivalent to > rt6_lookup(). Specifically, rt6_lookup() calls rt6_device_match() > while fib6_lookup() calls rt6_select() to match the oif. From a brief > glance, it does seem to be similar, especially consid

Re: [PATCH net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-20 Thread Wei Wang
On Thu, Jun 20, 2019 at 12:05 PM David Ahern wrote: > > From: David Ahern > > Gateway validation does not need a dst_entry, it only needs the fib > entry to validate the gateway resolution and egress device. So, > convert ip6_nh_lookup_table from ip6_pol_route to fib6_table_lookup > and ip6_route

[PATCH net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-20 Thread David Ahern
From: David Ahern Gateway validation does not need a dst_entry, it only needs the fib entry to validate the gateway resolution and egress device. So, convert ip6_nh_lookup_table from ip6_pol_route to fib6_table_lookup and ip6_route_check_nh to use fib6_lookup over rt6_lookup. ip6_pol_route is a