Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 11:43 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > > > This patch do not add dissection code: it use the info

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > This patch do not add dissection code: it use the information provided > > > by the available flowi4 structure. Moreove

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > This patch do not add dissection code: it use the information provided > > by the available flowi4 structure. Moreover the skb is not available on > > the calling site (in __ip_rout

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Tom Herbert
On Thu, Oct 29, 2015 at 8:00 AM, Paolo Abeni wrote: > On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: >> On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: >> > This patch changes how the multipath hash is computed for locally >> > generated UDP or TCP flows: now the hash comprises also

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > This patch do not add dissection code: it use the information provided > by the available flowi4 structure. Moreover the skb is not available on > the calling site (in __ip_route_output_key_hash) and pushing it all the > way will require a lo

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: > On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > > This patch changes how the multipath hash is computed for locally > > generated UDP or TCP flows: now the hash comprises also l4 information > > (source and destination port). > > > >

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > This patch changes how the multipath hash is computed for locally > generated UDP or TCP flows: now the hash comprises also l4 information > (source and destination port). > > This allows better utilization of the available paths when the exi

[PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-28 Thread Paolo Abeni
This patch changes how the multipath hash is computed for locally generated UDP or TCP flows: now the hash comprises also l4 information (source and destination port). This allows better utilization of the available paths when the existing flows have the same source IP and the same destination IP: