Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread David Miller
From: David Ahern Date: Tue, 25 Aug 2015 15:41:36 -0700 > Meaning rename struct inetpeer_addr to struct inetpeer_key and > addr_compare to entry_compare or key_compare? I'm not talking about inetpeer specifically, but generally speaking everywhere you're going to have to handle this including in

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread David Ahern
On 8/25/15 1:47 PM, David Miller wrote: From: David Ahern Date: Sun, 23 Aug 2015 20:01:34 -0600 On 8/23/15 6:15 PM, Thomas Graf wrote: On 08/23/15 at 08:26am, David Ahern wrote: inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry.

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread David Miller
From: David Ahern Date: Sun, 23 Aug 2015 20:01:34 -0600 > On 8/23/15 6:15 PM, Thomas Graf wrote: >> On 08/23/15 at 08:26am, David Ahern wrote: >>> inetpeer caches based on address only, so duplicate IP addresses >>> within >>> a namespace return the same cached entry. Similar to IP fragments >>>

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-25 Thread Thomas Graf
On 08/23/15 at 08:01pm, David Ahern wrote: > On 8/23/15 6:15 PM, Thomas Graf wrote: > >On 08/23/15 at 08:26am, David Ahern wrote: > >>inetpeer caches based on address only, so duplicate IP addresses within > >>a namespace return the same cached entry. Similar to IP fragments handle > >>duplicate ad

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-23 Thread David Ahern
On 8/23/15 6:15 PM, Thomas Graf wrote: On 08/23/15 at 08:26am, David Ahern wrote: inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry. Similar to IP fragments handle duplicate addresses across VRFs by adding the VRF master device index

Re: [PATCH net-next] inetpeer: Add support for VRFs

2015-08-23 Thread Thomas Graf
On 08/23/15 at 08:26am, David Ahern wrote: > inetpeer caches based on address only, so duplicate IP addresses within > a namespace return the same cached entry. Similar to IP fragments handle > duplicate addresses across VRFs by adding the VRF master device index to > the lookup. We have a lot of

[PATCH net-next] inetpeer: Add support for VRFs

2015-08-23 Thread David Ahern
inetpeer caches based on address only, so duplicate IP addresses within a namespace return the same cached entry. Similar to IP fragments handle duplicate addresses across VRFs by adding the VRF master device index to the lookup. Signed-off-by: David Ahern --- include/net/inetpeer.h | 11 +++