Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-08-09 Thread Willem de Bruijn
On Fri, Aug 9, 2019 at 2:58 PM Josh Hunt wrote: > > On 6/26/19 4:41 PM, Willem de Bruijn wrote: > > On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: > >> > >> > >> > >> On 6/14/19 4:53 PM, Jason Baron wrote: > >>> > >>> > >>> On 6/13/19 5:20 PM, Willem de Bruijn wrote: > >>> @@ -237,6 +237,

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-08-09 Thread Josh Hunt
On 6/26/19 4:41 PM, Willem de Bruijn wrote: On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: On 6/14/19 4:53 PM, Jason Baron wrote: On 6/13/19 5:20 PM, Willem de Bruijn wrote: @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-26 Thread Willem de Bruijn
On Wed, Jun 26, 2019 at 3:17 PM Jason Baron wrote: > > > > On 6/14/19 4:53 PM, Jason Baron wrote: > > > > > > On 6/13/19 5:20 PM, Willem de Bruijn wrote: > > @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 > > feature, unsigned long start) > >

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-26 Thread Jason Baron
On 6/14/19 4:53 PM, Jason Baron wrote: > > > On 6/13/19 5:20 PM, Willem de Bruijn wrote: > @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 > feature, unsigned long start) > NETIF_F_GSO_GRE_CSUM | \ >

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-14 Thread Jason Baron
On 6/13/19 5:20 PM, Willem de Bruijn wrote: @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start) NETIF_F_GSO_GRE_CSUM | \ NETIF_F_GSO_IPXIP4 |

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-13 Thread Willem de Bruijn
> >> @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 > >> feature, unsigned long start) > >> NETIF_F_GSO_GRE_CSUM | \ > >> NETIF_F_GSO_IPXIP4 | \ > >>

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-13 Thread Jason Baron
On 6/13/19 1:15 PM, Alexander Duyck wrote: > On Wed, Jun 12, 2019 at 4:14 PM Jason Baron wrote: >> >> Now that the stack supports UDP GRO, we can enable udp gso for virtual >> devices. If packets are looped back locally, and UDP GRO is not enabled >> then they will be segmented to gso_size via

Re: [PATCH net-next] gso: enable udp gso for virtual devices

2019-06-13 Thread Alexander Duyck
On Wed, Jun 12, 2019 at 4:14 PM Jason Baron wrote: > > Now that the stack supports UDP GRO, we can enable udp gso for virtual > devices. If packets are looped back locally, and UDP GRO is not enabled > then they will be segmented to gso_size via udp_rcv_segment(). This > essentiallly just reverts:

[PATCH net-next] gso: enable udp gso for virtual devices

2019-06-13 Thread Jason Baron
Now that the stack supports UDP GRO, we can enable udp gso for virtual devices. If packets are looped back locally, and UDP GRO is not enabled then they will be segmented to gso_size via udp_rcv_segment(). This essentiallly just reverts: 8eea1ca gso: limit udp gso to egress-only virtual devices. T