Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread David Miller
From: Daniel Borkmann Date: Mon, 13 Jul 2015 20:49:32 +0200 > ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] > and thus has no effect. Add a comment instead, explaining what happens and > why it's okay to just remove it. Since from user space side, a tail call is > inv

Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread Alexei Starovoitov
On 7/13/15 11:49 AM, Daniel Borkmann wrote: ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper

[PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread Daniel Borkmann
ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper function via bpf_tail_call_proto, the verifier