Re: [PATCH net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-19 Thread Heiner Kallweit
On 19.01.2021 23:02, Jakub Kicinski wrote: > On Sat, 16 Jan 2021 14:45:25 +0100 Heiner Kallweit wrote: >> The comment is quite weird, there is no such thing as a vendor-specific >> VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are >> doing here is simply checking whether the byte

Re: [PATCH net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-19 Thread Jakub Kicinski
On Sat, 16 Jan 2021 14:45:25 +0100 Heiner Kallweit wrote: > The comment is quite weird, there is no such thing as a vendor-specific > VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are > doing here is simply checking whether the byte at VPD address VPD_BASE > is a valid string LRDT

[PATCH net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-16 Thread Heiner Kallweit
The comment is quite weird, there is no such thing as a vendor-specific VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are doing here is simply checking whether the byte at VPD address VPD_BASE is a valid string LRDT, same as what is done a few lines later in the code. LRDT = Large