Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-05 Thread Hariprasad S
> On 05-Jan-2017, at 9:35 PM, David Miller wrote: > > From: Hariprasad Shenai > Date: Thu, 5 Jan 2017 11:23:10 +0530 > >> @@ -844,6 +848,10 @@ struct adapter { >>struct work_struct db_drop_task; >>bool tid_release_task_busy; >> >> +/* lock for mailbox cmd list */ >> +spinlo

Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-05 Thread David Miller
From: Hariprasad Shenai Date: Thu, 5 Jan 2017 11:23:10 +0530 > @@ -844,6 +848,10 @@ struct adapter { > struct work_struct db_drop_task; > bool tid_release_task_busy; > > + /* lock for mailbox cmd list */ > + spinlock_t mbox_lock; > + struct mbox_list mlist; > + ... > @

Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-05 Thread kbuild test robot
Hi Hariprasad, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Hariprasad-Shenai/cxgb4-Synchronize-access-to-mailbox/20170105-193032 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https

Re: [PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-05 Thread kbuild test robot
Hi Hariprasad, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Hariprasad-Shenai/cxgb4-Synchronize-access-to-mailbox/20170105-193032 config: i386-randconfig-x005-201701 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

[PATCH net-next] cxgb4: Synchronize access to mailbox

2017-01-04 Thread Hariprasad Shenai
The issue comes when there are multiple threads attempting to use the mailbox facility at the same time. When DCB operations and interface up/down is run in a loop for every 0.1 sec, we observed mailbox collisions. And out of the two commands one would fail with the present code, since we don't que