Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-27 Thread Hangbin Liu
On Wed, Jan 27, 2021 at 11:43:30AM +0200, Nikolay Aleksandrov wrote: > > For IGMP, although you said they are different. In my understanding, when > > bridge mac changed, we need to re-join multicast group, while a gratuitous > > ARP is also needed. I couldn't find a reason why IGMP message is OK b

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-27 Thread Nikolay Aleksandrov
On 27/01/2021 06:15, Hangbin Liu wrote: > On Tue, Jan 26, 2021 at 04:55:22PM +0200, Nikolay Aleksandrov wrote: Thanks for the reply. There are a few reasons I think the bridge should handle NETDEV_NOTIFY_PEERS: 1. Only a few devices will call NETDEV_NOTIFY_PEERS notifier: bond,

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Hangbin Liu
On Tue, Jan 26, 2021 at 04:55:22PM +0200, Nikolay Aleksandrov wrote: > >> Thanks for the reply. There are a few reasons I think the bridge should > >> handle NETDEV_NOTIFY_PEERS: > >> > >> 1. Only a few devices will call NETDEV_NOTIFY_PEERS notifier: bond, team, > >>virtio, xen, 6lowpan. There

[PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Hangbin Liu
After adding bridge as upper layer of bond/team, we usually clean up the IP address on bond/team and set it on bridge. When there is a failover, bond/team will not send gratuitous ARP since it has no IP address. Then the down layer(e.g. VM tap dev) of bridge will not able to receive this notificati

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Nikolay Aleksandrov
On 26/01/2021 15:56, Nikolay Aleksandrov wrote: > On 26/01/2021 15:25, Hangbin Liu wrote: >> On Tue, Jan 26, 2021 at 09:40:13AM +0200, Nikolay Aleksandrov wrote: >>> On 26/01/2021 06:09, Hangbin Liu wrote: After adding bridge as upper layer of bond/team, we usually clean up the IP address

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Nikolay Aleksandrov
On 26/01/2021 15:25, Hangbin Liu wrote: > On Tue, Jan 26, 2021 at 09:40:13AM +0200, Nikolay Aleksandrov wrote: >> On 26/01/2021 06:09, Hangbin Liu wrote: >>> After adding bridge as upper layer of bond/team, we usually clean up the >>> IP address on bond/team and set it on bridge. When there is a fa

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Hangbin Liu
On Tue, Jan 26, 2021 at 09:40:13AM +0200, Nikolay Aleksandrov wrote: > On 26/01/2021 06:09, Hangbin Liu wrote: > > After adding bridge as upper layer of bond/team, we usually clean up the > > IP address on bond/team and set it on bridge. When there is a failover, > > bond/team will not send gratuit

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-25 Thread Nikolay Aleksandrov
On 26/01/2021 06:09, Hangbin Liu wrote: > After adding bridge as upper layer of bond/team, we usually clean up the > IP address on bond/team and set it on bridge. When there is a failover, > bond/team will not send gratuitous ARP since it has no IP address. > Then the down layer(e.g. VM tap dev) of