Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread David Miller
From: Tobias Klauser Date: Tue, 10 Jan 2017 15:02:16 +0100 > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > are not used outide of bpf_lru_list.c > > This fixes the following GCC warnings when bui

Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread Martin KaFai Lau
On Tue, Jan 10, 2017 at 04:22:25PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 10, 2017 at 03:02:16PM +0100, Tobias Klauser wrote: > > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > > are not us

Re: [PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread Alexei Starovoitov
On Tue, Jan 10, 2017 at 03:02:16PM +0100, Tobias Klauser wrote: > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > are not used outide of bpf_lru_list.c > > This fixes the following GCC warnings when

[PATCH net-next] bpf: Make unnecessarily global functions static

2017-01-10 Thread Tobias Klauser
Make the functions __local_list_pop_free(), __local_list_pop_pending(), bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they are not used outide of bpf_lru_list.c This fixes the following GCC warnings when building with 'W=1': kernel/bpf/bpf_lru_list.c:363:22: warning: no prev