From: Nicolas Dichtel
Date: Fri, 9 Jun 2017 15:34:43 +0200
> Make it explicit in the log.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Nicolas Dichtel
I agree with others that we should rate limit this somehow given
the context in which it is invoked.
> > I just wonder if this should be rate limited?
> So using net_warn_ratelimited()?
>
> Displaying this message continuously in the log, even at a low rate, seems not
> the best things to do. The first time seems enough, but it would require more
> code for that. Is it not over-engineering?
Mayb
On Fri, Jun 09, 2017 at 04:39:06PM +0200, Nicolas Dichtel wrote:
> Le 09/06/2017 à 16:23, Andrew Lunn a écrit :
> > On Fri, Jun 09, 2017 at 03:34:43PM +0200, Nicolas Dichtel wrote:
> >> Make it explicit in the log.
> >>
> >> Suggested-by: Andrew Lunn
> >> Signed-off-by: Nicolas Dichtel
> >
> > H
Le 09/06/2017 à 16:23, Andrew Lunn a écrit :
> On Fri, Jun 09, 2017 at 03:34:43PM +0200, Nicolas Dichtel wrote:
>> Make it explicit in the log.
>>
>> Suggested-by: Andrew Lunn
>> Signed-off-by: Nicolas Dichtel
>
> Hi Nicolas
Hi Andrew,
>
> How often is this called? It seems like it is used by
On Fri, Jun 09, 2017 at 03:34:43PM +0200, Nicolas Dichtel wrote:
> Make it explicit in the log.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Nicolas Dichtel
Hi Nicolas
How often is this called? It seems like it is used by
ad_port_selection_logic, which has the comment:
is called in
Make it explicit in the log.
Suggested-by: Andrew Lunn
Signed-off-by: Nicolas Dichtel
---
drivers/net/bonding/bond_3ad.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index b44a6aeb346d..b15b177662b0 100644
--- a/drivers/n
