Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > And i will add the needed const attributes to these functions as part > of the IGMP patchset. Sounds good, not need for this revert then. Thanks, Vivien

Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Andrew Lunn
On Thu, Nov 09, 2017 at 09:39:32AM -0500, Vivien Didelot wrote: > We may have to pass a port's dedicated CPU port to port-wide functions > such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. > > The DSA port-wide functions currently take a non-const struct dsa_port * > as first arg

Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Florian Fainelli
On 11/09/2017 06:39 AM, Vivien Didelot wrote: > We may have to pass a port's dedicated CPU port to port-wide functions > such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. > > The DSA port-wide functions currently take a non-const struct dsa_port * > as first argument so we cannot

[PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"

2017-11-09 Thread Vivien Didelot
We may have to pass a port's dedicated CPU port to port-wide functions such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB. The DSA port-wide functions currently take a non-const struct dsa_port * as first argument so we cannot make cpu_dp const yet, even though it'd be more correct