Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-20 Thread Pablo Neira Ayuso
On Thu, Dec 20, 2018 at 03:51:00PM +0200, Or Gerlitz wrote: > On Thu, Dec 20, 2018 at 2:35 PM Pablo Neira Ayuso wrote: > > On Wed, Dec 19, 2018 at 04:26:53PM -0800, Jakub Kicinski wrote: > > > > I'm confused, could you rephrase? How does you work help such devices? > > > How is tc not suitable f

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-20 Thread Or Gerlitz
On Thu, Dec 20, 2018 at 2:35 PM Pablo Neira Ayuso wrote: > On Wed, Dec 19, 2018 at 04:26:53PM -0800, Jakub Kicinski wrote: > > I'm confused, could you rephrase? How does you work help such devices? > > How is tc not suitable for them? > There are two HW offload usecases: > > #1 Policy resides i

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-20 Thread Pablo Neira Ayuso
On Wed, Dec 19, 2018 at 04:26:53PM -0800, Jakub Kicinski wrote: > On Thu, 20 Dec 2018 01:03:13 +0100, Pablo Neira Ayuso wrote: > > On Wed, Dec 19, 2018 at 11:57:03AM -0800, Jakub Kicinski wrote: > > > > Anyway, the problem that this patchset addresses _already exists_ with > > > > ethtool_rxnfc and

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-19 Thread Jakub Kicinski
On Thu, 20 Dec 2018 01:03:13 +0100, Pablo Neira Ayuso wrote: > On Wed, Dec 19, 2018 at 11:57:03AM -0800, Jakub Kicinski wrote: > > > Anyway, the problem that this patchset addresses _already exists_ with > > > ethtool_rxnfc and cls_flower in place, it would be good to fix it now. > > > > That's

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-19 Thread Pablo Neira Ayuso
Dear Jakub, On Wed, Dec 19, 2018 at 11:57:03AM -0800, Jakub Kicinski wrote: [...] > > Anyway, the problem that this patchset addresses _already exists_ with > > ethtool_rxnfc and cls_flower in place, it would be good to fix it now. > > That's not the point of contention. What is your alternative

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-19 Thread Jakub Kicinski
On Tue, 18 Dec 2018 20:57:05 +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 17, 2018 at 05:39:29PM -0800, Jakub Kicinski wrote: > > On Fri, 14 Dec 2018 19:11:53 +0100, Pablo Neira Ayuso wrote: > > > * Do not expose TC software frontend details to the drivers anymore, > > > such as structure layo

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-18 Thread Pablo Neira Ayuso
Hi Jakub, On Mon, Dec 17, 2018 at 05:39:29PM -0800, Jakub Kicinski wrote: > On Fri, 14 Dec 2018 19:11:53 +0100, Pablo Neira Ayuso wrote: > > Hi, > > > > This patchset introduces a kernel intermediate representation (IR) to > > express ACL hardware offloads, this is heavily based on the existing >

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-17 Thread Jakub Kicinski
On Fri, 14 Dec 2018 19:11:53 +0100, Pablo Neira Ayuso wrote: > Hi, > > This patchset introduces a kernel intermediate representation (IR) to > express ACL hardware offloads, this is heavily based on the existing > flow dissector infrastructure and the TC actions. This IR can be used by > different

[PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-14 Thread Pablo Neira Ayuso
Hi, This patchset introduces a kernel intermediate representation (IR) to express ACL hardware offloads, this is heavily based on the existing flow dissector infrastructure and the TC actions. This IR can be used by different frontend ACL interfaces such as ethtool_rxnfc, tc and netfilter to repre