Re: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread David Miller
7, 2018 1:18 AM >> > To: David S . Miller >> > Cc: Vakul Garg ; Dave Watson >> > ; Boris Pismenny ; Aviad >> > Yehezkel ; netdev@vger.kernel.org; Doron >> > Roberts-Kedes >> > Subject: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path >&

Re: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread Doron Roberts-Kedes
> ; Boris Pismenny ; Aviad > > Yehezkel ; netdev@vger.kernel.org; Doron > > Roberts-Kedes > > Subject: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path > > without skb_cow_data. > > I prefer my name be removed from commit message. > Sure thing. Dave is t

RE: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-07 Thread Vakul Garg
Subject: [PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path > without skb_cow_data. > > decrypt_skb fails if the number of sg elements required to map is > greater than MAX_SKB_FRAGS. As noted by Vakul Garg, nsg must always be > calculated, but skb_cow_data adds unnecessary

[PATCH net-next,v3] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-06 Thread Doron Roberts-Kedes
decrypt_skb fails if the number of sg elements required to map is greater than MAX_SKB_FRAGS. As noted by Vakul Garg, nsg must always be calculated, but skb_cow_data adds unnecessary memcpy's for the zerocopy case. The new function skb_nsg calculates the number of scatterlist elements required to