Re: [PATCH net-nex 2/2] net: mvneta: Don't speed down the PHY when changing mtu

2020-07-29 Thread Jisheng Zhang
Hi David, On Tue, 28 Jul 2020 17:52:02 -0700 (PDT) David Miller wrote: > > > > @@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp) > > > > set_bit(__MVNETA_DOWN, &pp->state); > > > > - if (device_may_wakeup(&pp->dev->dev)) > > + if (device_may_wakeup(&pp->dev

Re: [PATCH net-nex 2/2] net: mvneta: Don't speed down the PHY when changing mtu

2020-07-28 Thread David Miller
From: Jisheng Zhang Date: Mon, 27 Jul 2020 19:53:14 +0800 > @@ -3651,7 +3651,8 @@ static void mvneta_stop_dev(struct mvneta_port *pp) > > set_bit(__MVNETA_DOWN, &pp->state); > > - if (device_may_wakeup(&pp->dev->dev)) > + if (device_may_wakeup(&pp->dev->dev) && > + pp->p

[PATCH net-nex 2/2] net: mvneta: Don't speed down the PHY when changing mtu

2020-07-27 Thread Jisheng Zhang
We found a case where the phy link speed is changed to 10Mbps then back to 1000Mbps when changing the mtu: ethtool -s eth0 wol g ip link set eth0 mtu 1400 Add a simple check to avoid unnecessary phylink_speed_down() when changing the mtu. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/m