On Dec 17 2007 14:43, David Miller wrote:
>> On Dec 13 2007 15:38, Joe Perches wrote:
>> >+static inline bool ipv4_is_private_10(__be32 addr)
>> >+{
>> >+ return (addr & htonl(0xff00)) == htonl(0x0a00);
>> >+}
>>
>> What are these functions needed for, even? There does not seem to be
>>
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Mon, 17 Dec 2007 23:37:24 +0100 (CET)
>
> On Dec 13 2007 15:38, Joe Perches wrote:
> >+static inline bool ipv4_is_private_10(__be32 addr)
> >+{
> >+return (addr & htonl(0xff00)) == htonl(0x0a00);
> >+}
>
> What are these functions needed
On Mon, 2007-12-17 at 23:37 +0100, Jan Engelhardt wrote:
> >+static inline bool ipv4_is_loopback(__be32 addr)
> >+{
> >+return (addr & htonl(0xff00)) == htonl(0x7f00);
> >+}
> >+
> Can we use __constant_htonl()?
I believe the generated code is the same.
> >+static inline bool ipv4_is_
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Mon, 17 Dec 2007 23:37:24 +0100 (CET)
> Can we use __constant_htonl()?
That should only be used in initializers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Dec 13 2007 15:38, Joe Perches wrote:
>
>Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET
>macros to inline functions ipv4_is_(__be32 addr)
>
>Adds type safety and arguably some readability.
>
>Changes since last submission:
>
>Removed ipv4_addr_octets function
>U
From: Joe Perches <[EMAIL PROTECTED]>
Date: Thu, 13 Dec 2007 15:38:54 -0800
> Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and
> ZERONET
> macros to inline functions ipv4_is_(__be32 addr)
>
> Adds type safety and arguably some readability.
>
> Changes since last submissio
Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET
macros to inline functions ipv4_is_(__be32 addr)
Adds type safety and arguably some readability.
Changes since last submission:
Removed ipv4_addr_octets function
Used hex constants
Converted recently added rfc3330 ma
