Re: [PATCH net-2.6.25] Name magic constants in sock_wake_async()

2007-11-26 Thread Herbert Xu
On Fri, Nov 23, 2007 at 04:43:11PM +0300, Pavel Emelyanov wrote: > The sock_wake_async() performs a bit different actions > depending on "how" argument. Unfortunately this argument > ony has numerical magic values. > > I propose to give names to their constants to help people > reading this fun

[PATCH net-2.6.25] Name magic constants in sock_wake_async()

2007-11-23 Thread Pavel Emelyanov
The sock_wake_async() performs a bit different actions depending on "how" argument. Unfortunately this argument ony has numerical magic values. I propose to give names to their constants to help people reading this function callers understand what's going on without looking into this function