Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-10-04 Thread Stephen Hemminger
On Fri, 28 Sep 2018 09:08:26 +0800 Hangbin Liu wrote: > Phil pointed out that there is a mismatch between vxlan and geneve ttl > inherit. > We should define it as a flag and use nla_put_flag to export this opiton. > > Fixes: 8fd780698745b ("vxlan: fill ttl inherit info") > Reported-by: Phil Sut

Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-29 Thread Hangbin Liu
On Fri, Sep 28, 2018 at 11:56:10AM -0600, David Ahern wrote: > On 9/28/18 6:38 AM, Hangbin Liu wrote: > > On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: > >> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > >>> Phil pointed out that there is a mismatch between vxlan and

Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-28 Thread David Ahern
On 9/27/18 7:08 PM, Hangbin Liu wrote: > Phil pointed out that there is a mismatch between vxlan and geneve ttl > inherit. > We should define it as a flag and use nla_put_flag to export this opiton. > > Fixes: 8fd780698745b ("vxlan: fill ttl inherit info") Wrong Fixes tag: kenny:mgmt:iproute2-n

Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-28 Thread David Ahern
On 9/28/18 6:38 AM, Hangbin Liu wrote: > On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: >> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: >>> Phil pointed out that there is a mismatch between vxlan and geneve ttl >>> inherit. >>> We should define it as a flag and use nl

Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-28 Thread Hangbin Liu
On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: > On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > > Phil pointed out that there is a mismatch between vxlan and geneve ttl > > inherit. > > We should define it as a flag and use nla_put_flag to export this opiton. > > s/o

Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-28 Thread Phil Sutter
On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > Phil pointed out that there is a mismatch between vxlan and geneve ttl > inherit. > We should define it as a flag and use nla_put_flag to export this opiton. s/opiton/option/ Apart from that, LGTM! Thanks, Phil

[PATCH net] vxlan: use nla_put_flag for ttl inherit

2018-09-27 Thread Hangbin Liu
Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. We should define it as a flag and use nla_put_flag to export this opiton. Fixes: 8fd780698745b ("vxlan: fill ttl inherit info") Reported-by: Phil Sutter Signed-off-by: Hangbin Liu --- drivers/net/vxlan.c | 8 +--