Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2018-01-23 Thread Xin Long
On Tue, Jan 23, 2018 at 6:35 AM, Roman Kapl wrote: > On 12/18/2017 07:20 AM, Xin Long wrote: >> >> Unlike ip tunnels, now vxlan doesn't do any pmtu update for >> upper dst pmtu, even if it doesn't match the lower dst pmtu >> any more. >> >> The problem can be reproduced when reducing the vxlan low

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2018-01-22 Thread Roman Kapl
On 12/18/2017 07:20 AM, Xin Long wrote: Unlike ip tunnels, now vxlan doesn't do any pmtu update for upper dst pmtu, even if it doesn't match the lower dst pmtu any more. The problem can be reproduced when reducing the vxlan lower dev's pmtu when running netperf. In jianlin's testing, the perform

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2017-12-21 Thread Xin Long
On Wed, Dec 20, 2017 at 2:38 AM, David Miller wrote: > From: Xin Long > Date: Wed, 20 Dec 2017 01:05:32 +0800 > >> On Wed, Dec 20, 2017 at 12:12 AM, David Miller wrote: >>> You're going to have to find a way to fix this without >>> invoking ->update_pmtu() on every single transmit. That's >>> r

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2017-12-19 Thread David Miller
From: Xin Long Date: Wed, 20 Dec 2017 01:05:32 +0800 > On Wed, Dec 20, 2017 at 12:12 AM, David Miller wrote: >> You're going to have to find a way to fix this without >> invoking ->update_pmtu() on every single transmit. That's >> really excessive, especially for an operation which is >> going

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2017-12-19 Thread Xin Long
On Wed, Dec 20, 2017 at 12:12 AM, David Miller wrote: > From: Xin Long > Date: Mon, 18 Dec 2017 14:20:56 +0800 > >> Unlike ip tunnels, now vxlan doesn't do any pmtu update for >> upper dst pmtu, even if it doesn't match the lower dst pmtu >> any more. >> >> The problem can be reproduced when redu

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

2017-12-19 Thread David Miller
From: Xin Long Date: Mon, 18 Dec 2017 14:20:56 +0800 > Unlike ip tunnels, now vxlan doesn't do any pmtu update for > upper dst pmtu, even if it doesn't match the lower dst pmtu > any more. > > The problem can be reproduced when reducing the vxlan lower > dev's pmtu when running netperf. In jianl

[PATCH net] vxlan: update skb dst pmtu on tx path

2017-12-17 Thread Xin Long
Unlike ip tunnels, now vxlan doesn't do any pmtu update for upper dst pmtu, even if it doesn't match the lower dst pmtu any more. The problem can be reproduced when reducing the vxlan lower dev's pmtu when running netperf. In jianlin's testing, the performance went to 1/7 of the previous. This pa